Repository navigation
feat: support SEAM_WEBHOOK_SECRET in webhook helper - #624
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Add SEAM_WEBHOOK_SECRET support to this maintained Seam SDK webhook helper and open a PR. This should be a small change: omitted constructor secret reads SEAM_WEBHOOK_SECRET; an explicitly supplied secret takes precedence. Preserve existing webhook verification semantics and idiomatic constructor usage. Include focused tests and examples. This is one of five parallel SDK PRs. No merge requested.
What Changed
Seam::Webhook.newtoSEAM_WEBHOOK_SECRETat construction, while preserving explicit-secret precedence.Risk Assessment
✅ Low: The change is bounded to constructor-time secret selection, preserves the verification path, and includes focused behavioral tests and examples.
Testing
All four real-SDK scenarios passed with independently signed synthetic events, and all focused webhook specs passed. Bundler's missing development dependency was bypassed without installing anything. Captured SDK transcript and reproducible driver; cleaned temporary state. No UI surface or background processes.
Evidence: Local SDK execution transcript
Real SDK accepted independently signed events and rejected wrong keys, tampering, expired timestamps, missing headers, and invalid secrets.Evidence: Reproducible independent HMAC SDK driver
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
ruby --version; bundle check— Ruby 4.0.0; Bundler reported missing development dependency addressable 2.9.1.MISE_STATE_DIR="$PWD/.test-state" ruby -Ilib -rseam -e 'puts "SDK loaded"'MISE_STATE_DIR="$PWD/.test-state" ruby -Ilib ~/seam/.firstmate/flagship/no-mistakes/evidence/01M7R3S5926GWV8JZR44A8VRHB/sdk_live.rb— exit 0.MISE_STATE_DIR="$PWD/.test-state" ruby -Ilib -S rspec --options /dev/null --require seam spec/webhook_spec.rb --format documentation— 35 examples, zero failures; bypassed unrelated shared WebMock/coverage setup.Read retained execution logs and actual exit statuses; removed disposable mise state; verified clean worktree.✅ **Document** - passed
✅ No issues found.
🔧 **Lint** - 1 issue found → no changes applied ✅
Gemfile.lock:1- Ruby lint verification is blocked:bundle exec standardrb lib/seam/webhook.rb spec/webhook_spec.rbcannot load the locked dependency addressable-2.9.1 because it is not installed. README Prettier and git diff whitespace checks passed; documentation already reflects the implementation. No tests or dependency installations were run.🔧 No changes applied.
✅ Re-checked - no issues remain.
✅ **Push** - passed
✅ No issues found.